Skip to content

🐛 fix OAS test #7535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

🐛 fix OAS test #7535

merged 1 commit into from
Apr 15, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 15, 2025

No description provided.

@odeimaiz odeimaiz self-assigned this Apr 15, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:api framework api, data schemas, labels Apr 15, 2025
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 15, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov
Copy link
Member

pcrespov commented Apr 15, 2025

Same as #7536

@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.55%. Comparing base (41523e7) to head (ad68dda).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7535      +/-   ##
==========================================
+ Coverage   87.46%   87.55%   +0.09%     
==========================================
  Files        1742      647    -1095     
  Lines       67432    30103   -37329     
  Branches     1144        0    -1144     
==========================================
- Hits        58982    26358   -32624     
+ Misses       8129     3745    -4384     
+ Partials      321        0     -321
Flag Coverage Δ
integrationtests 65.07% <ø> (-0.15%) ⬇️
unittests 86.69% <ø> (+0.03%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk ∅ <ø> (∅)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.30% <ø> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.01% <ø> (-1.10%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 86.02% <ø> (+0.08%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41523e7...ad68dda. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov mentioned this pull request Apr 15, 2025
Closed
1 task
pcrespov
pcrespov approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. I closed mine #7536

@pcrespov pcrespov merged commit 7b642fc into ITISFoundation:master Apr 15, 2025
87 of 89 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@odeimaiz odeimaiz

Labels

a:api framework api, data schemas, bug buggy, it does not work as expected

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

2 participants

@odeimaiz @pcrespov